-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Improve mobile view of permissions #27670
Conversation
left: -1111px; | ||
} | ||
|
||
.respTable td:before { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
::before
} | ||
|
||
.respTable td:before { | ||
float: left; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RTL?
} | ||
|
||
.respTable td:nth-child(1) { | ||
font-weight: bold; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
float: left; | ||
padding: 0 2em 0 0; | ||
content: attr(data-label) ":"; | ||
font-weight: bold; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
@include media-breakpoint-down(md) { | ||
.respTable { | ||
text-align: right; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RTL?
} | ||
|
||
.oddCol { | ||
background: $gray-100; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use background-color
@C-Lodder Thank you. |
administrator/components/com_foos
Outdated
@@ -0,0 +1 @@ | |||
/home/astrid/git/joomla-development/boilerplate/src/administrator/components/com_foos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't hate me 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not hate you. I hate git. Why does git always do things that I don't want? It's quite clear that I don't want to commit foo components in this PR, right?
components/com_foos
Outdated
@@ -0,0 +1 @@ | |||
/home/astrid/git/joomla-development/boilerplate/src/components/com_foos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again ;)
Yep, it is. |
I suggest some small modifications for joomla-tab.scss in order to be normalized compared to other scss.
|
@infograf768 I have changed it. I hope I've seen everything. |
looks ok, will test tomorrow. :) |
I have tested this item ✅ successfully on f41a4a0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27670. |
I have tested this item ✅ successfully on f41a4a0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27670. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27670. |
Thanks. |
Pull Request for Issue #27615 (comment) .
Summary of Changes
Show the columns in the permissions table below each other.
Testing Instructions
npm ci
.My changes
Actual result
Documentation Changes Required